PROMO: Actualize FSD titles #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azinit
commented
Feb 20, 2022
| @@ -22,7 +22,7 @@ const DOCUSAURUS_PLUGIN_OG = [ | |||
|
|
|||
| /** @type {Config["themeConfig"]["navbar"]} */ | |||
| const navbar = { | |||
| title: "feature-sliced", | |||
| title: "Feature-Sliced", | |||
There was a problem hiding this comment.
Тут полное название не вместить, т.к. и так много нав.пунктов (адаптив пострадает)
| @@ -19,34 +19,34 @@ sidebar_position: 2 | |||
|
|
|||
| To choose a clear name for an entity and understand its components, **you need to clearly understand what task will be solved with the help of all this code.** | |||
|
|
|||
| > *@sergeysova: During development, we try to give each entity or function a name that clearly reflects the intentions and meaning of the code being executed.* | |||
| > _@sergeysova: During development, we try to give each entity or function a name that clearly reflects the intentions and meaning of the code being executed._ | |||
There was a problem hiding this comment.
Видимо автофикс от md-плагина)
| @@ -53,7 +53,7 @@ sidebar_position: 1 | |||
| - [Why React developers should modularize their applications?](https://alexmngn.medium.com/why-react-developers-should-modularize-their-applications-d26d381854c1) | |||
There was a problem hiding this comment.
Ну и то же самое для русской версии
azinit
requested review from
AlexandrHoroshih,
akaia-shadowfox,
unordinarity,
Krakazybik and
Postamentovich
Krakazybik
approved these changes
Feb 20, 2022
AlexandrHoroshih
approved these changes
Feb 20, 2022
|
@AlexandrHoroshih @Krakazybik спасибо! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#399 (comment)
Changelog
Поменял офиц. название FSD - в ридмихе, лицензии и документации