Skip to content

Create more compatible binaries for all supported platforms #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 18, 2022

Conversation

torch2424
Copy link
Contributor

@torch2424 torch2424 commented Apr 15, 2022

This PR implements the Binary Compatible Builds Github Action from Wasmtime.

This allows us to execute the js-compute-runtime in Ubuntu 16, for our old Docker containers, or any extended security release linux users 😄

NOTE: The publishing job hasn't been tested, but all the artifacts are correctly added (old build example), so this should in theory work 😅

@torch2424 torch2424 marked this pull request as ready for review April 19, 2022 22:56
@torch2424 torch2424 requested a review from tschneidereit April 19, 2022 22:56
@tschneidereit tschneidereit force-pushed the torch2424/runtime-ubuntu-16-compatability branch 2 times, most recently from d8bacca to 0583d84 Compare May 18, 2022 12:50
@tschneidereit tschneidereit force-pushed the torch2424/runtime-ubuntu-16-compatability branch from 0583d84 to 45f4322 Compare May 18, 2022 12:59
Copy link
Contributor

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now fully works and also creates more compatible binaries for macOS and Windows

@tschneidereit tschneidereit changed the title Ubuntu 16 Compatible Builds in CI Create more compatible binaries for all supported platforms May 18, 2022
@tschneidereit tschneidereit merged commit 1bd34fe into main May 18, 2022
@tschneidereit tschneidereit deleted the torch2424/runtime-ubuntu-16-compatability branch May 18, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants