-
Notifications
You must be signed in to change notification settings - Fork 35
Create more compatible binaries for all supported platforms #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tschneidereit
merged 18 commits into
main
from
torch2424/runtime-ubuntu-16-compatability
May 18, 2022
Merged
Create more compatible binaries for all supported platforms #77
tschneidereit
merged 18 commits into
main
from
torch2424/runtime-ubuntu-16-compatability
May 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8bacca
to
0583d84
Compare
0583d84
to
45f4322
Compare
tschneidereit
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now fully works and also creates more compatible binaries for macOS and Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Binary Compatible Builds Github Action from Wasmtime.
This allows us to execute the
js-compute-runtime
in Ubuntu 16, for our old Docker containers, or any extended security release linux users 😄NOTE: The publishing job hasn't been tested, but all the artifacts are correctly added (old build example), so this should in theory work 😅