Skip to content

Updating the readme doc #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Updating the readme doc #70

merged 1 commit into from
Jun 8, 2022

Conversation

black2d
Copy link
Contributor

@black2d black2d commented Mar 7, 2022

Updating the readme to make it easier for new developers to compile the library.

An update to PR #57 and fixes #56.

Updating to add additional steps for building as well as options for testing dev releases.
@black2d
Copy link
Contributor Author

black2d commented Jun 7, 2022

@tschneidereit any update on merging this?

@elliottt elliottt self-requested a review June 8, 2022 01:03
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These build directions are great, thank you for putting them together!

I only had one comment about debian packages being available, feel free to ignore it :)

Comment on lines +52 to +55
curl -sS -L -O https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-12/wasi-sdk-12.0-linux.tar.gz
tar xf wasi-sdk-12.0-linux.tar.gz
sudo mkdir -p /opt/wasi-sdk
sudo mv wasi-sdk-12.0/* /opt/wasi-sdk/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth pointing out that there's a .deb available for ubuntu/debian users?

@elliottt elliottt merged commit 68e7802 into fastly:main Jun 8, 2022
@black2d
Copy link
Contributor Author

black2d commented Jun 8, 2022

@elliottt no worries I wrote them a few months back. I may take another pass on a fresh load and make sure nothing has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large Compilations
2 participants