Allow URLSearchParams to be used as a base class to extend from within application javascript #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/extend-from-textencoder
branch
3 times, most recently
from
7884fde to
006f585
Compare
JakeChampion
force-pushed
the
jake/extend-from-urlsearchparams
branch
from
1518d0f to
4f0fd2b
Compare
JakeChampion
force-pushed
the
jake/extend-from-textencoder
branch
from
006f585 to
d96d475
Compare
JakeChampion
force-pushed
the
jake/extend-from-urlsearchparams
branch
3 times, most recently
from
31736a1 to
a186188
Compare
elliottt
suggested changes
Jun 22, 2022
Comment on lines
+978
to
+979
| bool append(JSContext *cx, unsigned argc, Value *vp); | ||
|
|
There was a problem hiding this comment.
I was wondering where the implementations for these prototypes were, and it's down on line 6935 on main -- the URLSearchParams namespace is reopened three times throughout js-compute-builtins.cpp. We should do some reorganization soon so that we don't need prototypes so far from the definitions :)
Comment on lines
6747
to
6748
| if (!self) | ||
| return false; |
There was a problem hiding this comment.
I'm not sure this is necessary here -- line 6744 is using JS::GetReservedSlot on self.
There was a problem hiding this comment.
good spot, this was meant to be url_search_params_instance
JakeChampion
commented
Jun 22, 2022
elliottt
approved these changes
Jun 22, 2022
JakeChampion
force-pushed
the
jake/extend-from-urlsearchparams
branch
from
95473a3 to
9a14faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is part of the solution for #113
This pull-request changes our URLSearchParams implementation to use JS_NewObjectForConstructor when the construction has come from the applications' JavaScript, which assigns the correct prototype to the instance being constructed (taking into account extends in JavaScript)
I've also added a test which confirms that the correct prototype has been assigned when extending from URLSearchParams, the test is written in a way that makes it simpler to add the same test for any other builtin classes