Skip to content

Cache more in CI #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Cache more in CI #112

merged 6 commits into from
Jun 16, 2022

Conversation

jameysharp
Copy link
Contributor

Here are more experiments in caching various steps that run in GitHub Actions.

@jameysharp jameysharp force-pushed the jsharp/cache-more branch 3 times, most recently from f067021 to 22ce570 Compare June 16, 2022 20:13
I'm also only copying js-compute-runtime.wasm into the job's uploaded
artifacts, not any temporary files generated during the build.
...and also rely on CI-provided versions of rustup, even on Mac.
The idea here is to use rustup and the Rust toolchain configured in the
outer container, while using the C toolchain from the inner Centos
container.
If `main` is uncached, then each new pull request starts with an empty
cache.

But ignore the build cache on tagged releases. This is possibly
excessive caution. It ensures that artifacts published with a release of
this SDK aren't corrupted by broken caches.
@jameysharp jameysharp marked this pull request as ready for review June 16, 2022 21:40
@jameysharp jameysharp requested a review from elliottt June 16, 2022 21:40
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for improving build times!

make -f ../c-dependencies/js-compute-runtime/Makefile
rm *.{d,o}
cd ..
run: make -C c-dependencies/js-compute-runtime DESTDIR=$PWD install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jameysharp jameysharp merged commit 03a3064 into main Jun 16, 2022
@jameysharp jameysharp deleted the jsharp/cache-more branch June 16, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants