Skip to content

Remove husky from the integration tests package.json #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

elliottt
Copy link
Contributor

@elliottt elliottt commented Jun 16, 2022

This was installing pre-commit hooks to run prettier, which is injecting a lot of noise into commits. Let's hold off on git hooks for now, and discuss enforcing js/yaml/etc formatting with a ci job instead.

@elliottt elliottt force-pushed the trevor/no-prettier branch from cdccec4 to b35a890 Compare June 16, 2022 20:25
@elliottt elliottt changed the title Remove prettier and husky from the integration tests package.json Remove husky from the integration tests package.json Jun 16, 2022
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@elliottt elliottt merged commit 9746f80 into main Jun 16, 2022
@elliottt elliottt deleted the trevor/no-prettier branch June 16, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants