enable running the sdk-tests locally #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
commented
Jun 16, 2022
Comment on lines
5
to
7
| const fetch = require("node-fetch"); | ||
| const chalk = require("chalk"); | ||
| require("better-logging")(console, { |
There was a problem hiding this comment.
If we can replace these dependencies with nodejs built-in packages such as http, then we will no longer need to have a build step nor need to commit the dist directory as we could run this file directly with GitHub Actions
JakeChampion
force-pushed
the
jake/local-integration-tests
branch
from
66027e7 to
f768827
Compare
elliottt
approved these changes
Jun 16, 2022
…tion specific functions in the sdk-test script I've chosen to hard-code the test configuration path as we only have one configuration file To run the integration tests locally we can now do this: `cargo build --release && node .github/actions/compute-sdk-test/main.js`
JakeChampion
force-pushed
the
jake/local-integration-tests
branch
from
f768827 to
743793f
Compare
JakeChampion
force-pushed
the
jake/local-integration-tests
branch
from
743793f to
d59c180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get the tests working locally and I couldn't get the
actto work correctly, which is what run-local-integration-tests.sh relied on.I thought we could perhaps make it so that the sdk-tests github action does not rely on anything github action specific and then we can run the action's script ourselves via
node .github/actions/compute-sdk-test/main.js.To do this I've chosen to hard-code the test configuration path as we only have one configuration file, this removed the need for the github action specific
@actions/corenpm package. We also had in the code the@actions/githubpackage but were never using it, so that has also been removed.The final change needed to make running the tests locally was to update the
npm run build:testcommand to look for thejs-compute-runtimecli within./target/release/.To run the integration tests locally we can now do this:
cargo build --release && node .github/actions/compute-sdk-test/main.jsNote: During the combining of the different repositories we brought in a git pre-commit hook which is running a code-formatter on any modified files, this is why the commits contain lots of format changes.