remove packing ability and requirement for fastly.toml file to exist when using the js-compute-runtime cli #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/no-fastly-toml
branch
from
196665b to
a1e5300
Compare
JakeChampion
force-pushed
the
jake/no-fastly-toml
branch
3 times, most recently
from
5fca086 to
9d7fda4
Compare
jameysharp
approved these changes
Jun 16, 2022
JakeChampion
force-pushed
the
jake/no-fastly-toml
branch
from
57bed77 to
0b6de1e
Compare
added 2 commits
June 17, 2022 10:49
…mpute-runtime cli and no longer create a tarball as these pieces of functionaliy are now handled by the fastly cli itself (https://developer.fastly.com/reference/cli/compute/)
…uirement from the js-compute-runtime cli
JakeChampion
force-pushed
the
jake/no-fastly-toml
branch
from
0b6de1e to
e098a84
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to create a tarball was useful before the official fastly cli had the ability to package and deploy c@e projects. As these pieces of functionaliy are now handled by the fastly cli itself (specifically this function is used) - we can remove them from the js-compute-cli project.