Flare: ensure discrete event flush is disabled during initial DOM mount #15701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: d7afe23...9da4c7f react-dom
Generated by 🚫 dangerJS |
|
Maybe we should just revert the warning entirely if it's causing problems? Until we can verify that this approach is correct, and write tests. If the point is to unblock the sync then we should change as little as possible about the current behavior. |
|
@acdlite I've added a regression test that confirms the expected behaviour. |
|
We will come back to this one in the future. Closing this in favour of #15702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing #15687 internally, we encountered some issues where the invariant in
flushDiscreteUpdatesfired during legit tests.The reason for this was because ReactDOM sets properties and attributes on elements on initial mount, which can also fire events on the DOM. We don't want these events to flush discrete events, so we now set a flag for this that we enable before setting DOM properties and then disable after setting them.
Furthermore, we felt that the
invariantwas maybe too strong, so this has been downgraded to a warning in DEV.