Make useEffect(async) warning more verbose #14327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
verbose-warning
branch
from
2a53198 to
f9342ac
Compare
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: a7f270c...ea1a9f4 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
sophiebits
approved these changes
Nov 26, 2018
| 'supported, but you can call an async function inside an ' + | ||
| 'effect.' | ||
| ? '\n\nIt looks like you wrote useEffect(async () => ...) or returned a Promise. ' + | ||
| 'Instead, you may write an async function separately, ' + |
There was a problem hiding this comment.
no comma after separately please
Jessidhia
reviewed
Nov 27, 2018
| 'and then call it from inside the effect:\n\n' + | ||
| 'async function fetchComment(commentId) {\n' + | ||
| ' // You can await here\n' + | ||
| '}\n\n' + |
There was a problem hiding this comment.
More of a question: would it be better to write this function inside the effect callback instead?
Supposedly, the engine would only have to evaluate the function declaration when the effect callback is called, but I'm not sure it'd help anyway as it'd still have to create the shared closure object.
At any rate, writing it outside the component entirely would definitely be better.
There was a problem hiding this comment.
I don't really have an opinion on this but it's nice to show it doesn't have to be inside.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Make useEffect(async) warning more verbose * Nit
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Make useEffect(async) warning more verbose * Nit
|
Is there a tracking bug for data fetching solution (possibly with error handling / timeout included)? Just being curious whether it will fit other use-cases too e.g Fetch API streaming body or Web Worker postMessage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a more detailed message. People still get tripped over this:
New message: