Skip to content

Use a better* solution for the missing CMD file issue on Windows #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use a better* solution for the missing CMD file issue on Windows #3829

wants to merge 2 commits into from

Conversation

BYK
Copy link

@BYK BYK commented Jan 17, 2018

This is a follow up to #3806. Instead of recreating the file and
leaving it there, we trick CMD to stop reading the file after the
first line by modifying the CMD script.

*This is a "better" solution because:

  1. It doesn't leave obsolete files around
  2. This fix can be incorporated into npm and yarn via https://github.com/npm/cmd-shim/

This is a follow up to #3806. Instead of recreating the file and
leaving it there, we trick CMD to stop reading the file after the
first line by modifying the CMD script.

*This is a "better" solution because:

1. It doesn't leave obsolete files around
2. This fix can be incorporated into npm and yarn via https://github.com/npm/cmd-shim/
@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2018

Looks like Windows still fails :-(

The batch file cannot be found.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] eject: `react-scripts eject`

@BYK
Copy link
Author

BYK commented Jan 17, 2018

Ah, of course, because I cannot rewrite a file that's being run at the time 😞

I'll reopen this when I figure it out.

@BYK BYK closed this Jan 17, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants