Feat/4 implement User #30

minjun3021 · 2023-07-12T15:07:18Z

What is this PR?

Github Issue: 회원 기능 구현 #4

Key Changes

Test Checklist

junha-ahn

코틀린 스프링부트에 관한 내용이 많아서 보기 어려운것들은 패스하고, 아는 한에서 열심히 댓글 달아봤습니다 :)

src/main/kotlin/com/group4/ticketingservice/controller/UserController.kt

src/main/kotlin/com/group4/ticketingservice/TicketingserviceApplication.kt

src/main/kotlin/com/group4/ticketingservice/controller/UserController.kt

src/main/kotlin/com/group4/ticketingservice/entity/User.kt

src/main/kotlin/com/group4/ticketingservice/service/impl/UserServiceImpl.kt

src/main/kotlin/com/group4/ticketingservice/utils/Authority.kt

src/main/kotlin/com/group4/ticketingservice/service/UserDetailService.kt

junha-ahn · 2023-07-16T15:28:05Z

Todo

가장 최신의 Main branch에 내용을 해당 브랜치에 적용시켜주세요. (여러 CI 작업이 포함되어있습니다)
브랜치 이름 변경: rule
- remote branch 이름 변경은 삭제로 가능하다, PR 보호를 위해 해당 브랜치는 이름 변경 안해도 됩니다.

.gitignore

src/main/kotlin/com/group4/ticketingservice/service/impl/UserServiceImpl.kt

src/main/kotlin/com/group4/ticketingservice/service/UserDetailService.kt

src/main/kotlin/com/group4/ticketingservice/service/impl/UserServiceImpl.kt

src/main/kotlin/com/group4/ticketingservice/TicketingserviceApplication.kt

junha-ahn · 2023-07-17T13:20:11Z

test 작성시 참고: Spring Security가 적용된 곳을 효율적으로 테스트하자.

아마 로그인 관련 로직 unit test는 자료 조사가 많이 필요할 것 같습니다. (통합테스트는 아직입니다 #31 에서 준비중)

junha-ahn

유닛 테스트 / 통합 테스트

SignIn, GetAceessToken 테스트는 그대로 Integration 에서 진행하고
CreateUser에 대한 Controller Test는 src/test/ 밑으로 옮기면 될것 같습니다.
필요없어진 TestUserDetailService는 삭제 부탁드립니다.

의견

Fake Object TestUserDetailService 의 관리가 점점 부담으로 다가올 것으로 예상
각 테스트 단위로 메서드를 쉽게 Mock up할 수 있지만 Fake Object는 input에 대한 조건문을 구현해야하는 복잡성
createUser는 spring security 관련 의존성이 없으니 슬라이스 테스트(src/test/...) 진행

src/test/kotlin/com/group4/ticketingservice/user/UserControllerTest.kt

src/integrationTest/kotlin/com/group4/ticketingservice/User/UserControllerTest.kt

src/main/kotlin/com/group4/ticketingservice/controller/UserController.kt

src/main/kotlin/com/group4/ticketingservice/service/UserService.kt

src/test/kotlin/com/group4/ticketingservice/bookmark/BookmarkControllerTest.kt

…gnup)

junha-ahn

KtFormat 돌려 주세요! 이제 끝이네요! 굳입니다 👍

src/integrationTest/kotlin/com/group4/ticketingservice/User/UserControllerTest.kt

src/main/kotlin/com/group4/ticketingservice/TicketingserviceApplication.kt

src/main/kotlin/com/group4/ticketingservice/config/Config.kt

src/main/resources/application.properties

src/test/resources/application.properties

hihahayoung

수고수고했습니다!

minjun3021 added 5 commits July 5, 2023 01:00

fix : change plugin version

5b6d1a3

feature : create dev profile , entities

78a9b34

feature : create spring security config, userdetails

dc98a9d

feature : create user register

38ba2b2

feature : add authentication method (JWT)

a1f2cce

junha-ahn requested review from ParkJeongseop, bohblue2, yunsuu and junha-ahn July 12, 2023 15:30

junha-ahn assigned minjun3021 Jul 12, 2023

junha-ahn requested changes Jul 12, 2023

View reviewed changes

junha-ahn mentioned this pull request Jul 17, 2023

로그인/인증 흐름도 작성 #35

Closed

junha-ahn requested changes Jul 17, 2023

View reviewed changes

minjun3021 added 2 commits July 17, 2023 23:04

refactor : move request/response class to dto

4781748

refactor : remove service interface

2284691

junha-ahn linked an issue Jul 17, 2023 that may be closed by this pull request

회원 기능 구현 #4

Closed

junha-ahn changed the title ~~Feature/4 user register~~ Feat/4 implement User Jul 17, 2023

minjun3021 added 11 commits July 20, 2023 01:58

fix : change jwtFilter logic

db71c8e

chore: merge from main branch (for integration test)

a0196d8

feat: move jpa auditing config

326f37f

test: add jwt config

a648366

feat : change mariadb to mysql

6f2b744

chore: setup config for docker-compose

c008137

fix : change table name, remove admin authority

048d135

feat: authenticate user at jwtAuthenticationFilter , not controller

9298b2f

feat: add jwtAuthorizationFilter

c78a1ce

feat: add guide about AuthenticationPrincipal

20d6ee9

feat: make @withauthuser, some test codes

2098c5c

minjun3021 added 12 commits July 30, 2023 14:57

fix: change usercreate logic

15a41d0

chore: remove dev profile at gitignore

4c59842

feat: add access_token_info endpoint at userController

3e0c6e3

fix: change dto field nullable for test code

9f9bb52

feat : make Spring security work perfectly in test code.

2ae27fd

feat: use only testField object

f40a04f

feat: add all case test code

bf87757

chore: remove csrf config

48973f4

feat: add method creating wrong jwt for intergration test

82a4ea5

feat: create usercontroler test (intergration)

8b2b638

chore: move file to user package

57b3172

feat: userRepository test

f84b873

junha-ahn requested changes Jul 31, 2023

View reviewed changes

minjun3021 added 8 commits July 31, 2023 22:57

chore: remove login test at unit test

a84cf90

chore: remove sign up test at intergration test

e999611

chore: match test method name to url

08d440a

feat: apply securityConfig to bookmarktest

3ef00ff

feat: change integrationTest method name

f3739fe

chore: change endpoint name (login->signin , post /users -> /users/si…

3b5079e

…gnup)

fix : use GSON

11dd01c

feat: add test case about pw encoder

6272327

junha-ahn requested changes Jul 31, 2023

View reviewed changes

minjun3021 added 3 commits August 1, 2023 12:18

chore: remove useless imports

1174efa

chore: move jwt secret properties to environment variable

eb65333

chore: apply code review

e15e7f1

minjun3021 mentioned this pull request Aug 1, 2023

Test Coverage 80% rule 준수 #57

Closed

1 task

chore: merge from main

da709a4

hihahayoung approved these changes Aug 1, 2023

View reviewed changes

junha-ahn merged commit 027b988 into main Aug 1, 2023

junha-ahn deleted the Feature/4-user-register branch August 1, 2023 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/4 implement User #30

Feat/4 implement User #30

minjun3021 commented Jul 12, 2023 •

edited by junha-ahn

Loading

junha-ahn left a comment •

edited

Loading

junha-ahn commented Jul 16, 2023 •

edited by minjun3021

Loading

junha-ahn commented Jul 17, 2023 •

edited

Loading

junha-ahn left a comment •

edited

Loading

junha-ahn left a comment

hihahayoung left a comment

Feat/4 implement User #30

Feat/4 implement User #30

Conversation

minjun3021 commented Jul 12, 2023 • edited by junha-ahn Loading

What is this PR?

Key Changes

Test Checklist

junha-ahn left a comment • edited Loading

Choose a reason for hiding this comment

junha-ahn commented Jul 16, 2023 • edited by minjun3021 Loading

junha-ahn commented Jul 17, 2023 • edited Loading

junha-ahn left a comment • edited Loading

Choose a reason for hiding this comment

유닛 테스트 / 통합 테스트

junha-ahn left a comment

Choose a reason for hiding this comment

hihahayoung left a comment

Choose a reason for hiding this comment

minjun3021 commented Jul 12, 2023 •

edited by junha-ahn

Loading

junha-ahn left a comment •

edited

Loading

junha-ahn commented Jul 16, 2023 •

edited by minjun3021

Loading

junha-ahn commented Jul 17, 2023 •

edited

Loading

junha-ahn left a comment •

edited

Loading