Added #define LED_BUILTIN to all pins_arduino.h that need it.

[lbernstone]

Fixes #4134

[me-no-dev]

LED_BUILTINB?

[me-no-dev]

how does a define and a const char coexist?

static const uint8_t LED_BUILTIN = 4;
#define LED_BUILTIN

[atanisoft]

this and other cases should be #define LED_BUILTIN LED_BUILTIN

[atanisoft]

how does a define and a const char coexist?

static const uint8_t LED_BUILTIN = 4;
#define LED_BUILTIN

The #define variant is used by the pre-processor and the other by the compiler during code generation. The pre-processor can not see static const variables unfortunately (even static constexpr ... would be invisible)

[me-no-dev]

this works:

static const uint8_t LED_BUILTIN = 4;
#define LED_BUILTIN LED_BUILTIN

int main(){
#ifdef LED_BUILTIN
	printf("LED_BUILTIN: %u\n", LED_BUILTIN);
#endif
    return 0;
}

[atanisoft]

Yes, but this won't:

static const uint8_t LED_BUILTIN = 4;

int main(){
#ifdef LED_BUILTIN
	printf("LED_BUILTIN: %u\n", LED_BUILTIN);
#endif
    return 0;
}

The ifdef block will be excluded from compilation.

[me-no-dev]

yes yes :) i got the problem. PR needs fixing :) likle find and replace 😄

[atanisoft]

Can you back out this commit so I can submit a PR to fix it?

This PR hasn't been merged yet and is still pending here for fixes.

[lbernstone]

No good deed goes unpunished.