Skip to content

UpdateClass::printError should take a Print instead of a Stream #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssilverman opened this issue Aug 5, 2019 · 10 comments
Closed

UpdateClass::printError should take a Print instead of a Stream #3067

ssilverman opened this issue Aug 5, 2019 · 10 comments
Labels
Status: Stale Issue is stale stage (outdated/stuck)

Comments

@ssilverman
Copy link

UpdateClass::printError should take a Print and not a Stream. It's not possible to pass in custom Print implementations without also implementing Stream.

See:

void printError(Stream &out);

puuu added a commit to puuu/MQTT433gateway that referenced this issue Sep 4, 2019
@stale
Copy link

stale bot commented Oct 4, 2019

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Oct 4, 2019
@ssilverman
Copy link
Author

Any word on this? (Just pinging the issue to avoid it being auto-closed.)

@stale
Copy link

stale bot commented Oct 4, 2019

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the Status: Stale Issue is stale stage (outdated/stuck) label Oct 4, 2019
@atanisoft
Copy link
Collaborator

@ssilverman send a PR with the update and I'm sure @me-no-dev will consider it.

@stale
Copy link

stale bot commented Dec 3, 2019

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Dec 3, 2019
@puuu
Copy link
Contributor

puuu commented Dec 10, 2019

Please have also a look, how this was fixed for the esp8266 platform: esp8266/Arduino#4117

@stale
Copy link

stale bot commented Dec 10, 2019

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the Status: Stale Issue is stale stage (outdated/stuck) label Dec 10, 2019
@stale
Copy link

stale bot commented Feb 8, 2020

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Feb 8, 2020
@stale
Copy link

stale bot commented Feb 22, 2020

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

@puuu
Copy link
Contributor

puuu commented Feb 23, 2020

Please see pull request #3763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Development

No branches or pull requests

3 participants