-
Notifications
You must be signed in to change notification settings - Fork 7.6k
UpdateClass::printError should take a Print instead of a Stream #3067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Any word on this? (Just pinging the issue to avoid it being auto-closed.) |
[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future. |
@ssilverman send a PR with the update and I'm sure @me-no-dev will consider it. |
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Please have also a look, how this was fixed for the esp8266 platform: esp8266/Arduino#4117 |
[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future. |
[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions. |
Please see pull request #3763 |
UpdateClass::printError
should take aPrint
and not aStream
. It's not possible to pass in customPrint
implementations without also implementingStream
.See:
arduino-esp32/libraries/Update/src/Update.h
Line 81 in fa55a2c
The text was updated successfully, but these errors were encountered: