Skip to content

Automatically run ranlib on archives with missing index #9758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 1, 2019

No description provided.

@sbc100 sbc100 requested a review from kripken November 1, 2019 18:22
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean my PR #9755 to document the ranlib issue is not needed, as now we run it automatically on demand?

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 1, 2019

yes, although I would hope the auto-indexing might not be permanent and its still better to use the right tools up front, and if you use -Werror or STRICT you still need to do it yourself since you'll get a warning when we do it for you implicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants