Skip to content

capitalize mode name "TypeScript" #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022
Merged

capitalize mode name "TypeScript" #160

merged 1 commit into from
Feb 23, 2022

Conversation

trev-dev
Copy link
Contributor

I realize this is picky, but TypeScript is a name, and like names (and titles), they should be capitalized. Thanks for the light-weight major mode!

Screenshot from 2022-02-18 16-26-30

vs

Screenshot from 2022-02-18 16-27-05

@josteink
Copy link
Member

Hey hey! Thanks for the PR!

Just one question: Does this impact language detection in other modes like lsp-mode or dap-mode?

Have you tested that? 😄

@trev-dev
Copy link
Contributor Author

Hmm, it didn't yesterday after I changed it, but I run Emacs as a daemon. After rebooting and firing up for some super healthy Saturday morning work, all LSP would look for is eslint...

Leave this with me and I'll see what I can do

@trev-dev
Copy link
Contributor Author

Hokay so I double-checked the documentation on defined-derived-mode and the 3rd argument is indeed just a descriptor for the mode, I don't believe it has any functional impact other than the modeline display.

Also, I have this fun thing that happens with lsp-mode where it sometimes fails at finding the correct project root and I have to delete my workspace folder and re-try. I did this and LSP-Mode found my tsconfig and fired up.

I did not test dap-mode as I do not use it :)

@josteink
Copy link
Member

If so, let's just merge it.

If it causes trouble down the line, surely somebody will let us know :)

@josteink josteink merged commit 84ff422 into emacs-typescript:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants