-
Notifications
You must be signed in to change notification settings - Fork 64
分库分表: 排序merger的nullable数据的支持 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #195 +/- ##
==========================================
+ Coverage 85.85% 85.91% +0.05%
==========================================
Files 44 45 +1
Lines 3274 3309 +35
==========================================
+ Hits 2811 2843 +32
- Misses 372 374 +2
- Partials 91 92 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
我已经验证过了,如果用户直接使用基本类型去接收 NULL,会出现 error。但是如果用户用基本类型的指针去接收 NULL,那么能够正常处理。 @longyue0521 的说法应该算是正确的,也就是我们倾向于认为用户应该使用 sql.NullXXX 类型或者自己实现类似的类型去处理 NULL 列。可惜的是 sql.NullXXX 出现得比较晚,所以目前 GO 这边的传统是用指针。 这也是很无奈的事情。 最后一点,将这个 err error 放进去 if ok 内部。然后再将文件名改名为 convert_assign.go 和 convert_assign_test.go |
把 deepsource 修一下,把 convertAssign 改名叫做 sqlConvertAssign。这个 deepsource 有点蠢。 |
@longyue0521 可以再看看,没问题就直接合并了。 |
好的 |
在sortmerger中支持nullable类型,大佬们看看这样搞可以不