Skip to content

HTTPClient - Fix case sensitivity for header keys #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024
Merged

HTTPClient - Fix case sensitivity for header keys #2185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f4002
HTTPClient - Fix case sensitivity for header keys
earlephilhower May 30, 2024
56e0ca6
Merge branch 'master' into h1
earlephilhower May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/HTTPClient/src/HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ void HTTPClient::collectHeaders(const char* headerKeys[], const size_t headerKey

String HTTPClient::header(const char* name) {
for (size_t i = 0; i < _headerKeysCount; ++i) {
if (_currentHeaders[i].key == name) {
if (_currentHeaders[i].key.equalsIgnoreCase(name)) {
return _currentHeaders[i].value;
}
}
Expand All @@ -982,7 +982,7 @@ int HTTPClient::headers() {

bool HTTPClient::hasHeader(const char* name) {
for (size_t i = 0; i < _headerKeysCount; ++i) {
if ((_currentHeaders[i].key == name) && (_currentHeaders[i].value.length() > 0)) {
if ((_currentHeaders[i].key.equalsIgnoreCase(name)) && (_currentHeaders[i].value.length() > 0)) {
return true;
}
}
Expand Down