Skip to content

Update hd44780_I2Cexp.h #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mattncsu
Copy link

@mattncsu mattncsu commented Aug 4, 2018

I had to add (byte) to the endTransmission statement to get the library to compile for ESP32 in Arduino 1.8.5.

I had to add (byte) to the endTransmission statement to get the library to compile for ESP32 in Arduino 1.8.5
@bperrybap
Copy link
Contributor

bperrybap commented Aug 4, 2018

I've replicated the issue.
I'll probably pull this in or do something similar; however this is a work around since this is really an issue in the ESP32 core Wire library and it affects more than just the I2Cexp i/o class in hd44780. It also affects many other existing 3rd party i2c applications and 3rd party i2c libraries.
On 2018-06-27 they updated the code to include a new endTransmission(bool) function. This breaks any code that uses endTransmission(0) or endTransmission(1)
They need to remove this new function to maintain Wire API compatibility.
I'm in the process of getting this information to them.
Hopefully they will fix this asap.
ESP32 core issue is here: espressif/arduino-esp32#1725

@bperrybap
Copy link
Contributor

I went a different route for this fix. The endTransmission(1) calls were used vs endTransmission() to work around a bug in the TinyWireM library. Now the the TinyWireM library has been fixed, the hd44780 code can use endTransmission() which avoids the bug in the ESP32 core.

The hd44780 library has been updated and released as 1.0.1
It has been pushed to github and should be available to the IDE library manager within the hour.
This should resolve your issues.

I'm still trying to get the ESP32 core developers to accept that they have an issue that they need to fix.

@bperrybap bperrybap closed this Aug 6, 2018
@mattncsu
Copy link
Author

mattncsu commented Aug 7, 2018

Thanks for looking in to it, I've done my share of fighting with TinyWireM too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants