docs: Fix typos #1124
Merged
docs: Fix typos #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Nov 12, 2021
| @@ -631,7 +631,7 @@ Here's an example that might give you a better understanding of how | |||
| from returns.io import IOResultE | |||
| from returns.context import ReaderIOResultE | |||
|
|
|||
| @final | |||
There was a problem hiding this comment.
I guess this is not a typo. @final protocols are ones that cannot be subclasses by other protocols.
Or am I missing something? 🤔
There was a problem hiding this comment.
Referring to python/mypy#8316:
from typing import Protocol, Callable, Any, final
@final
class User(Protocol):
fetch: Callable[[int], dict[str,Any]]
# error: Final class t.User has abstract attributes "fetch"
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 79 79
Lines 2338 2338
Branches 153 153
=========================================
Hits 2338 2338 Continue to review full report at Codecov.
|
sobolevn
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:
final: python/mypy#8316
I have made things!
Checklist
CHANGELOG.mdRelated issues
🙏 Please, if you or your company finds
dry-pythonvaluable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.