-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Blazor] Prepare for custom cache removal #61666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As discovered in #61790, we need to update tests |
@maraf auto used that to determine when it needed to start in wasm mode vs when it needed to start in server mode. How are we handling that? |
Both tests failing on CI passed locally, re-trying
|
@javiercn It has it's own local storage item with value of assemblies hash. The check for |
If I understood this correctly, we are putting a hash on local storage to track this? who's putting the hash (Blazor? the wasm runtime?) Where does it get it from? (since there's no longer a blazor.boot.json file) |
I didn't need to touch this implementation. Blazor already did it this way. |
cacheBootResources
from Auto render mode detection
In the dotnet/runtime#114901 we are removing custom cache. The current auto render mode detection is based on assumption "has user previously used the current version (hash) of application?". Whether custom cache was used or not should not matter, as proper HTTP cache should ensure all the assets are cached.