Skip to content

Don't strip debugging symbols in the regular Debian images #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Don't strip debugging symbols in the regular Debian images #693

merged 1 commit into from
Feb 7, 2022

Conversation

malor
Copy link
Contributor

@malor malor commented Feb 5, 2022

Since #687, the regular Debian images no longer ship DWARF symbols, which heavily limits the ability to use gdb and lldb for debugging.

Stripping debugging symbols makes perfect sense to reduce the size of Docker images, but when this optimization was first introduced in #483, the idea was to restrict its use to the slim and Alpine images. That was (unintentionally?) changed in #483, and now debugging symbols are also stripped in the regular Debian images. Undo that change.

Fixes #694 .

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch!

Since #687, the regular Debian images no longer ship DWARF symbols,
which heavily limits the ability to use gdb and lldb for debugging.

Stripping debugging symbols makes perfect sense to reduce the size
of Docker images, but when this optimization was first introduced
in #483, the idea was to restrict its use to the slim and Alpine images.
That was (unintentionally?) changed in #483, and now debugging symbols
are also stripped in the regular Debian images. Undo that change.
@malor malor requested a review from tianon February 7, 2022 19:32
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@tianon tianon merged commit 19739a9 into docker-library:master Feb 7, 2022
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 7, 2022
Changes:

- docker-library/python@19739a9: Merge pull request docker-library/python#693 from malor/debian-debuggability
- docker-library/python@1b6bc0c: Don't strip debugging symbols in the regular Debian images
@malor malor deleted the debian-debuggability branch February 8, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian images no longer ship DWARF debugging symbols
2 participants