Skip to content

Add initial GitHub Actions CI #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Add initial GitHub Actions CI #1011

merged 1 commit into from
Aug 28, 2020

Conversation

tianon
Copy link
Member

@tianon tianon commented Apr 29, 2020

See docker-library/bashbrew#2. 👍

(This is currently failing due to https://bugs.php.net/bug.php?id=79445, but I wanted to get it open to have a place to record the link to that bug. 😅)

@smola
Copy link

smola commented Jul 24, 2020

@tianon This is currently failing due to https://bugs.php.net/bug.php?id=79445, but I wanted to get it open to have a place to record the link to that bug.

Adding some retries does the job: --retry 3 - retry-delay 5 --connect-timeout 10.
See: https://github.com/smola/docker-php/actions/runs/181799744

@tianon
Copy link
Member Author

tianon commented Aug 21, 2020

@tianon This is currently failing due to https://bugs.php.net/bug.php?id=79445, but I wanted to get it open to have a place to record the link to that bug.

Adding some retries does the job: --retry 3 - retry-delay 5 --connect-timeout 10.
See: https://github.com/smola/docker-php/actions/runs/181799744

Sorry for the delay -- I like that there's a workaround, but I'm honestly concerned that the solution is "just hit it until it works" which doesn't feel particularly kind to the upstream infrastructure (especially since we'd be adding those lines just to make GitHub Actions work, since it works fine everywhere else). 😞

@tianon
Copy link
Member Author

tianon commented Aug 28, 2020

Oh snap, it's fully green (90 checks, the full suite twice!)

@yosifkit yosifkit merged commit b44c4f1 into master Aug 28, 2020
@yosifkit yosifkit deleted the github-actions branch August 28, 2020 18:18
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 29, 2020
Changes:

- docker-library/php@2f5aa9a: Merge pull request docker-library/php#1052 from infosiftr/jq-template
- docker-library/php@165f8ca: Add initial jq-based templating engine
- docker-library/php@b44c4f1: Merge pull request docker-library/php#1011 from docker-library/github-actions
- docker-library/php@5dc2907: Add initial GitHub Actions CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants