Skip to content

Account for more edge cases in entrypoint scripts #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

tianon
Copy link
Member

@tianon tianon commented Apr 6, 2017

Not sure what to do about --config, since that makes things a lot more complicated to handle properly, but this at least allows users to still specify things like --port and not break initdb.

Not sure what to do about `--config`, since that makes things a _lot_ more complicated to handle properly, but this at least allows users to still specify things like `--port` and not break initdb.
@yosifkit
Copy link
Member

yosifkit commented Apr 6, 2017

Not sure what to do about the users with a config file that specifies ssl key files but then we turn off ssl through the flags for the short init part and mongo fails to start.

They can work around it by skipping the entrypoint, but lose the init user creation and chown.

$ docker run -d --user mongo --entrypoint mongod mongo:3.4 --config /path/to/mongo.conf

@tianon
Copy link
Member Author

tianon commented Apr 7, 2017

Yeah, I'm not sure either, especially since the config file is a really irritatingly structured YAML, hence # TODO what do to about "--config" ? :( in this PR 😇 😞

@tianon
Copy link
Member Author

tianon commented Apr 7, 2017

(In other words, this is still better than what we've got now -- our alternative is to back out of the initdb behavior entirely, which is not great IMO)

@yosifkit
Copy link
Member

yosifkit commented Apr 7, 2017

I guess add a warning to the docs along with the new initialization variables and information. We could also do versions that don't do initialization scripts or user creation?

@tianon
Copy link
Member Author

tianon commented Apr 7, 2017

Wouldn't that be easier to just add an environment variable for, or to show users how to use --entrypoint to skip our scripts entirely?

@yosifkit yosifkit merged commit 017d431 into docker-library:master Apr 7, 2017
@yosifkit yosifkit deleted the existing-args branch April 7, 2017 17:09
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 7, 2017
- `drupal`: 8.3.0 (docker-library/drupal#78), remove 8.2 (docker-library/drupal#80)
- `ghost`: add `alpine` variant (docker-library/ghost#55)
- `mongo`: more edge cases (docker-library/mongo#167, docker-library/mongo#169)
- `postgres`: adjust append (docker-library/postgres#270)
- `rabbitmq`: add `vm_memory_high_watermark` support based on cgroup limits (docker-library/rabbitmq#105)
- `rocket.chat`: 0.55.0-rc.1
- `wordpress`: add `wp-cli` variant (docker-library/wordpress#198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants