Implement jq templating #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
templating
branch
3 times, most recently
from
a7ccf38 to
9ab7a0e
Compare
LaurentGoderre
changed the title
LaurentGoderre
force-pushed
the
templating
branch
from
9ab7a0e to
da70bf6
Compare
yosifkit
reviewed
Oct 18, 2023
| @@ -1,13 +1,14 @@ | |||
| FROM alpine:3.18 | |||
| FROM alpine:{{ env.variant | ltrimstr("alpine") }} | |||
There was a problem hiding this comment.
I think a future goal would be to combine the Alpine and Debian templates into one to ensure that the common bits and flow remain in sync. This can be a future PR or added to this one 🤷.
LaurentGoderre
force-pushed
the
templating
branch
from
da70bf6 to
d7a4c27
Compare
yosifkit
reviewed
Oct 18, 2023
yosifkit
reviewed
Oct 18, 2023
LaurentGoderre
force-pushed
the
templating
branch
from
d7a4c27 to
88e2559
Compare
LaurentGoderre
force-pushed
the
templating
branch
from
88e2559 to
8b76567
Compare
yosifkit
approved these changes
Oct 20, 2023
yosifkit
added a commit
to docker-library/oi-janky-groovy
that referenced
this pull request
Oct 20, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 20, 2023
Changes: - docker-library/memcached@1cd4fbf: Merge pull request docker-library/memcached#93 from LaurentGoderre/templating - docker-library/memcached@8b76567: Implement jq templating
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 9, 2023
Changes: - docker-library/memcached@471a298: Update 1 to alpine 3.19 - docker-library/memcached@9cd87ed: Merge pull request docker-library/memcached#94 from infosiftr/one-template - docker-library/memcached@52c3fa2: Update templating to pin to only major version and use a single template - docker-library/memcached@1cd4fbf: Merge pull request docker-library/memcached#93 from LaurentGoderre/templating - docker-library/memcached@8b76567: Implement jq templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.