Skip to content

Upstream updates #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Upstream updates #1

wants to merge 7 commits into from

Conversation

astro
Copy link

@astro astro commented Jan 16, 2018

There have been breaking changes in svd2rust and the cortex-m crate. I re-ran svd2rust. Unfortunately, this drops all of the manual improvements.

@astro
Copy link
Author

astro commented Jan 18, 2018

Here's more on the motivation behind the new I/O model: http://blog.japaric.io/brave-new-io/

@dkarwowski
Copy link
Owner

Ill likely take a look at this tomorrow or sometime during the weekend, and regenerate with the customized patch.

If you want, the patched svd is checked in under the dev branch and you can try regenerating with that, too.

@astro
Copy link
Author

astro commented Feb 5, 2018

Sorry, but svd2rust is missing SPI1 with the changes:

stm32f429x $ svd2rust --target cortex-m -i STM32F429x.svd
error: No register SPI1 in peripheral SPI1
note: run with `RUST_BACKTRACE=1` for a backtrace

BTW:

diff --git STM32F429x.svd STM32F429x.svd
index 7550930..95e9702 100644
--- STM32F429x.svd
+++ STM32F429x.svd
@@ -13297,7 +13297,7 @@ xs:noNamespaceSchemaLocation="CMSIS-SVD_Schema_1_1.xsd">
                   <description>Next transfer is CRC</description>
                   <value>1</value>
                 </enumeratedValue>
-              </enumeratedValue>
+              </enumeratedValues>
             </field>
             <field>
               <name>DFF</name>
@@ -13323,7 +13323,7 @@ xs:noNamespaceSchemaLocation="CMSIS-SVD_Schema_1_1.xsd">
               <bitOffset>10</bitOffset>
               <bitWidth>1</bitWidth>
               <enumeratedValues derivedFrom="SPI1.CR1.BIDIOE.ENABLER">
-              </enumeratedvalues>
+              </enumeratedValues>
             </field>
             <field>
               <name>SSM</name>

@astro
Copy link
Author

astro commented Feb 15, 2018

No pressure, just a reminder. :-) Thanks in advance!

@astro
Copy link
Author

astro commented Mar 6, 2018

Nevermind, I have switched to crate stm32f429 which has appeared in the meanwhile. :-)

@astro astro closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants