-
Notifications
You must be signed in to change notification settings - Fork 653
fix(testing): Function signature of assertObjectEquals() does not accept interfaces #741 #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it would be good to fixe this issue. @wperron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, but please revert the formatting changes as they're not pertinent to the change.
@wperron done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
The type
Record<PropertyKey, unknown>
used inassertObjectEquals()
does not accept interface types as an argument.The solution is to change
assertObjectMatch
first param fromunknown
toany
.