Issue/165 #1
Open
Issue/165 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prettier to autoformat JS code - eslint to lint code - jsconfig.json to make VSC happy and able to discover njs-types - moved jsdoc/conf.json to .jsdocsrc.json
|
VSC still reports some issues, but |
need to use the same njs-types as it is used NJS_VERSION to properly lint agains the right version
- r.variables contains only strings, so r.variables.cache_instance_credentials_enabled == 1 may cause issues - updated typedef S3ReqParams and make properties optional - NjsStringOrBuffer has no indexOf, so explicitly invoke toString() - import Credentials typedefs where missed
4141done
reviewed
Aug 18, 2023
There was a problem hiding this comment.
I like that we are putting the jsdoc config into a more standard place with this change.
Although we're not adding anything to the merge path, I am still of the opinion that eslint and prettier should both be separate PRs for three reasons:
- A general practice of keeping PRs about one thing.
- Allowing focused discussion on choices for the configuration of each tool by us and the community.
- In my experience, formatting is better introduced along with a CI gate on formatting for merge. Otherwise we're constantly reminding people to format and diffs get confusing.
ivanitskiy
commented
Aug 18, 2023
|
well when semi: true: VSC code complains about it: |
That smells like an issue with your editor config. Strange that it would be flagging semicolons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure VSC can identify njs-types and added eslint, prettier and misc changes