-
Notifications
You must be signed in to change notification settings - Fork 34
fix: Update plotly to v2.29, resolve some rendering issues #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
- Coverage 46.11% 46.00% -0.11%
==========================================
Files 628 635 +7
Lines 37826 37917 +91
Branches 9532 9555 +23
==========================================
+ Hits 17443 17445 +2
- Misses 20329 20418 +89
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the e2e tests failed
- v2.28 had some fixes for M1 macs, including for the scattergl issue we've fallen back to scatter for in the past - Did not resolve the range breaks issue, so that still requires `scatter` type - See https://github.com/plotly/plotly.js/is sues/3522 for more details - Tested on M1 mac, ensured plots were appearing correctly. Will verify e2e tests as well
9bb13e5
to
f705346
Compare
tests/figure.spec.ts-snapshots/can-open-a-simple-figure-1-firefox-linux.png
Outdated
Show resolved
Hide resolved
This reverts commit f705346.
- Some test environments may not support it
I'm not sure why it's not rendering lines in scattergl. When I try on codepen with the same data/layout, it all seems to work fine. Perhaps something wrong with the plotly modules we're including?? Error in the logs:
Which looks like https://stackoverflow.com/questions/73403994/plotly-js-with-webgl-over-the-vuejs-app-not-working-webgl-invalid-operation-u |
- For some reason they're not drawing at all. Needs some more investigation...
This reverts commit 98f73ee.
- Deleted `package-lock.json`, ran `npm run clean`, then ran `npm install` again - Plotly lines work again in scattergl. I officially hate computers.
This reverts commit 8e97e42.
- Will uninstall and reinstall it, see if that fixes things
- Now it works
scatter
typescattergl
modenpm uninstall react-plotly.js --workspace packages/chart
andnpm uninstall react-plotly.js --workspace packages/chart
followed bynpm install plotly.js --workspace packages/chart
andnpm install react-plotly.js --workspace packages/chart