Fix the torch.take() wrapper to make axis optional for ndim = 1 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezcano
approved these changes
Jul 15, 2023
| if axis is None: | ||
| if x.ndim != 1: | ||
| raise ValueError("axis must be specified when ndim > 1") | ||
| axis = 0 |
There was a problem hiding this comment.
Or you can dispatch to torch.take, either should be alright.
There was a problem hiding this comment.
torch.take doesn't support an axis argument.
There was a problem hiding this comment.
exactly :D torch.take() == numpy.take(axis=None)
There was a problem hiding this comment.
it's a bit more general, as it sees the whole tensor as a 0dim tensor and indexes into it, so it also works for ndim > 1.
There was a problem hiding this comment.
Right. The flattening behavior is also there in NumPy, but I think we wanted to avoid that with the array API take. I'm not sure to what degree we should try to avoid that for the compat library, though (c.f. #34 (comment))
betatim
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34