Skip to content

MAINT: don't import helpers in numpy namespace #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

MAINT: don't import helpers in numpy namespace #327

merged 2 commits into from
May 15, 2025

Conversation

crusaderky
Copy link
Contributor

#288 accidentally re-added lines (I assume after a bad merge from main) that were recently deleted in #302.

@ev-br it would be good to have this in the release.

@Copilot Copilot AI review requested due to automatic review settings May 15, 2025 08:44
Copilot
Copilot AI reviewed May 15, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unintended helper imports from the numpy namespace to align with recent changes.

  • Removed the wildcard import from common helpers.
  • Replaced an import from .linalg with a corrected version using type ignore comments.

@ev-br ev-br merged commit 1b4ba64 into data-apis:main May 15, 2025
23 checks passed
@ev-br
Copy link
Member

ev-br commented May 15, 2025

Thanks

@ev-br ev-br added this to the 1.12 milestone May 15, 2025
@crusaderky crusaderky deleted the import_helpers branch May 16, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ev-br ev-br ev-br approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @ev-br