Side-effect free & lazy multiprocessing context #5475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
@jakirkham @mrocklin @martindurant could you please have a look at this? Seems like these are remnants of using "forkserver" multiprocessing context (#687) and side-effects caused by importing modules (#2627). Reworked and rebased the PR to:
Slack conversation for reference: https://dask.slack.com/archives/C019Q0QSD4J/p1635504992026200 |
|
If I remember this issue clearly, my point was about setting up things like event loops and server components - but I think @jcrist fixed the specific point I found. My memory is a little hazy here. I don't really know the ramifications of preloading modules for forkserver; but only doing so for the case that we actually use the forkserver seems sensible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util._initialize_mp_context/util.mp_context(or basically importing anything from distributed) imports numpy (additional package) as a side-effect, which increases the memory usage by roughly ~100MiB. This change defers the creation of the multiprocessing context from "import time" to "runtime"Related to PrefectHQ/prefect#5087 (comment)
pre-commit run --all-files