Skip to content

Show application mode in footer #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented May 26, 2019

Display the application mode in the footer, when it is not equal to PRODUCTION. This is useful for troubleshooting and development.

I am planning to use a different response in the services in an mode (e.g. offline, for #75 and #77 ). This way we will be able to run the UI completely offline, with some mocked data. But also use other modes like development that could still point to development UI servers.

@kinow kinow self-assigned this May 26, 2019
@kinow
Copy link
Member Author

kinow commented May 26, 2019

To review/test this PR, this vue.js doc page has more about modes, and it's possible to runt he cylc-ui project alone simulating modes, e.g.

$ NODE_ENV=staging npm run serve

image

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #80 into master will increase coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #80     +/-   ##
=========================================
+ Coverage   77.41%   78.22%   +0.8%     
=========================================
  Files          13       13             
  Lines         124      124             
=========================================
+ Hits           96       97      +1     
+ Misses         28       27      -1
Impacted Files Coverage Δ
src/store/index.js 95.65% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9538c...2faa059. Read the comment docs.

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this.

  • Common sense testing I've tested this by setting export NODE_ENV="My Name is Tim". This appears to work.
  • Looking at the code

@kinow
Copy link
Member Author

kinow commented Jun 20, 2019

Thanks for testing it Tim!!!

@kinow kinow merged commit c4757c3 into cylc:master Jun 20, 2019
@kinow kinow added this to the 0.1 milestone Sep 10, 2019
@kinow kinow deleted the show-mode-footer branch October 30, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants