Migrate to jsonschema 4.18 #264
Conversation
+ Deprecates "memory:" URIs in favor of the registry behavior. + Fixes a bunch of tests that referenced completely invalid specifications.
+ jsonschema 4.18 doesn't support Python below 3.8, so we can't either
|
This will also drop support for Python 3.7 because jsonschema>=4.18 doesn't support it 🤷. I'm thinking that I'll tag versions starting with this as |
+ Also fix the tests so that they actually test using a different validator (using the `any` keyword which was removed in DRAFT-04). Signed-off-by: Chris Wacek <[email protected]>
+ Also fix the tests so that they actually test using a different validator (using the `any` keyword which was removed in DRAFT-04). Signed-off-by: Chris Wacek <[email protected]>
| "six>=1.5.2", | ||
| ], | ||
| cmdclass=versioneer.get_cmdclass(), | ||
| classifiers=[ | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.7", |
There was a problem hiding this comment.
In addition to updating the classifiers, I suggest also passing python_requires=">=3.8" to setup, though I think everything will work out okay even if this is not done.
This project has not been using the python_requires argument before. But classifiers are advisory in nature, and I believe pip will never treat them as constraints that need to be solved when resolving specific dependency versions.
However, everything should be okay even without it, because while classifiers aren't constraints, dependency version ranges in install_requires are. Because jsonschema 4.18 itself constrains the Python version to be >=3.8, I think pip on Python 3.7 will correctly manage to select an appropriate lower version of both python-jsonschema-objects and jsonschema.
This adds support for jsonschema >4.18, but breaks support below that because of the breaking changes in that library.