Handle float operation errors when using divmod #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue of multipleOf When float numbers are involved in a divmod operation the Remainder may be a number close to 0 or to the Divisor and both scenarios mean that the Divisor is a perfect divisor of the dividend.
this will work as long as the numbers are larger than 0.0000000000000001
Signed-off-by: Chris Wacek <[email protected]>
|
@azubieta see the change I made. If the tests pass I'll merge this version. |
|
@cwacek using Decimal does the job. I just fixed a small typo. Looks good from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #259