build: Update versioneer from 0.15 to 0.29 #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One benefit of this update is to support the upcoming Python 3.12 release. Old versioneer versions use configparser.SafeConfigParser. This was deprecated back in Python 3.2, and being removed in 3.12. Procedure followed for the update: - Manually removed the code appended by the old version to the end of __init__.py, which the update will not do. (When this is not done, it appends improved but similar code after it.) - In the top-level repository directory (i.e., the directory that directly contains setup.py), followed the current instructions for a "Vendored mode" installation, by installing the versioneer package in a temporary virtual environment and running "versioneer install --vendor". As expected, this reported that the old versioneer.py was replaced, and that the effect of running the new script was to create _version.py and append to __init__.py.
This reformats the new code with black that was generated in the previous commit with versioneer, as was done in 7da92e2 (except here the *only* reformatted code is versioneer-generated code). This does *not* include the vendored versioneer.py script itself, which we retain unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One benefit of this update is to support the upcoming Python 3.12 release. (Though other changes, in addition to and unrelated to versioneer, may also need to be made in order to fully support 3.12.) Old versioneer versions use
configparser.SafeConfigParser. This was deprecated back in Python 3.2. It is finally being removed in 3.12.Procedure followed for the update:
__init__.py, which the update will not do. (When this is not done, it appends improved but similar code after it.)setup.py), followed the current instructions for a "Vendored mode" installation, by installing the versioneer package in a temporary virtual environment and runningversioneer install --vendor.As expected, this reported that the old versioneer.py was replaced, and that the effect of running the new script was to create
_version.pyand append to__init__.py.