Optional FK-Truncation / Rake update #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading old(er) projects dependencies, including annotate, causes loads of random changes which are not of any use, spamming git history with noise. comments-only-changes.
also, upgrading rake too then causes a downgrade form 2.7 to order version, causing further noise.
without exaggerating, i almost died because of this. twice.
always trying to keep my history clean, i made fk-truncation optional and allowing rake 12. feel free.
Sorry for the bad vibes, but, based on my perspective, this was quite a waste of time to force change into existing annotations.
To let it sparkle however, thanks for this -gem-, literally. Cheers