Ensure "--args" is last argument of gdb command #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good to me. I fixed the missing import that caused the build to fail, but otherwise am leaving unchanged. |
|
I did some testing and found it didn't work if Test plan for my changes: Run the following and after each, confirm "Load Binary" still works (if the mi2 interpreter flag isn't passed to gdb, this isn't apparent until the binary is loaded).
Can anyone confirm this fixes their issues? cc @zhidvegi, @sammcdsam fixes #272 |
To debug an application+command line arguments "--args" is used as last command line argument of gdbgui. Everything after "--args" must be passed then to gdb also as LAST command line argument. This was not the case, but it is now ensured. By default gdb is now used in any case with "--args".
|
I'll leave this open a couple more days if anyone wants to test it before I merge it to master. |
cs01
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Ensure "--args" is last argument of gdb command To debug an application+command line arguments "--args" is used as last command line argument of gdbgui. Everything after "--args" must be passed then to gdb also as LAST command line argument. This was not the case, but it is now ensured. By default gdb is now used in any case with "--args". * fix formatting * only pass args when they are present * add unit tests * add additional test case Co-authored-by: Chad Smith <[email protected]>
cs01
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Ensure "--args" is last argument of gdb command To debug an application+command line arguments "--args" is used as last command line argument of gdbgui. Everything after "--args" must be passed then to gdb also as LAST command line argument. This was not the case, but it is now ensured. By default gdb is now used in any case with "--args". * fix formatting * only pass args when they are present * add unit tests * add additional test case Co-authored-by: Chad Smith <[email protected]>
cs01
pushed a commit
that referenced
this pull request
Jul 18, 2020
* Ensure "--args" is last argument of gdb command To debug an application+command line arguments "--args" is used as last command line argument of gdbgui. Everything after "--args" must be passed then to gdb also as LAST command line argument. This was not the case, but it is now ensured. By default gdb is now used in any case with "--args". * fix formatting * only pass args when they are present * add unit tests * add additional test case Co-authored-by: Chad Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To debug an application+command line arguments "--args" is used as last command line argument of gdbgui. Everything after "--args" must be passed then to gdb also as LAST command line argument.
This was not the case, but it is now ensured. By default gdb is now used in any case with "--args".