Support sub project build without parent Cargo.toml. #438

avkviring · 2020-06-29T17:05:47Z

No description provided.

avkviring · 2020-06-29T17:07:50Z

Hi, I have some project.

- root
-- Client/Cargo.toml
-- Common/Cargo.toml
-- Server/Cargo.toml

This command don't work:
cross build --manifest-path clients/Cargo.toml --target armv7-linux-androideabi --release

This PR fixed this problem.

reitermarkus · 2020-06-29T18:38:39Z

src/cli.rs

    let mut target_dir = None;
    let mut sc = None;
    let mut all: Vec<String> = Vec::new();

    {
        let mut args = env::args().skip(1);
        while let Some(arg) = args.next() {
+            if all.last().unwrap_or(&"".to_string()) == "--manifest-path" {


Why all.last() when we are using an iterator? Use the same pattern as for the other flags below.

reitermarkus · 2020-06-29T18:40:03Z

src/cli.rs

 }

 pub fn parse(target_list: &TargetList) -> Args {
    let mut channel = None;
    let mut target = None;
+    let mut project_dir: Option<String> = None;


Use a PathBuf to store this.

reitermarkus · 2020-06-29T18:45:00Z

src/cli.rs

    let mut target_dir = None;
    let mut sc = None;
    let mut all: Vec<String> = Vec::new();

    {
        let mut args = env::args().skip(1);
        while let Some(arg) = args.next() {
+            if all.last().unwrap_or(&"".to_string()) == "--manifest-path" {
+                project_dir = Option::Some(format!("{}/{}", env::current_dir().expect("").to_str().unwrap(), arg.to_string()));


Use Path::join instead of format!.

reitermarkus · 2020-06-29T21:38:55Z

This command don't work:
cross build --manifest-path clients/Cargo.toml --target armv7-linux-androideabi --release

Can you post the output of the failed command?

reitermarkus · 2020-06-30T03:25:03Z

src/cli.rs

-            if let ("+", ch) = arg.split_at(1) {
+            if arg == "--manifest-path" {
+                all.push(arg);
+                let path = args.next().expect("Missing argument in --manifest-path");


Use if let Some(..) for this and also add the case for --manifest-path=.

This command don't work:
cross build --manifest-path clients/Cargo.toml --target armv7-linux-androideabi --release

Can you post the output of the failed command?

It is fallback to host cargo and fail in linking

I don't understand :-( I am newbies in rust, please help me.

Look at the code below, there it is used in the same way.

if let Some(path) = args.next() {

reitermarkus · 2020-06-30T03:25:24Z

src/cargo.rs

@@ -26,7 +26,7 @@ impl Subcommand {
            _ => true,
        }
    }
-
+    


Please fix the trailing whitespace everywhere.

The whitespace is still there, please remove it.

src/cli.rs

reitermarkus · 2020-07-02T01:12:41Z

src/cargo.rs

@@ -26,7 +26,7 @@ impl Subcommand {
            _ => true,
        }
    }
-
+    


The whitespace is still there, please remove it.

reitermarkus · 2020-07-02T01:13:14Z

src/cli.rs

    {
        let mut args = env::args().skip(1);
        while let Some(arg) = args.next() {
-            if let ("+", ch) = arg.split_at(1) {
+            if arg == "--manifest-path" {


Still needs the case for --manifest-path=.

reitermarkus · 2020-07-16T15:18:33Z

@avkviring, any update on this?

avkviring · 2020-07-27T05:24:48Z

@avkviring, any update on this?
Hi, I have vacation and don't have computer now :-(

wngr · 2020-12-02T11:12:45Z

I'd be interested in taking this over, if there is no disagreement.

Edit: I addressed the outstanding comments in https://github.com/wngr/cross/tree/wngr/master
However, there are a bunch of changes on the files from running cargo fmt -- is this projected manually formatted?

avkviring · 2020-12-03T15:22:57Z

Hi, it is very good news :-)

cross-rs#438 credit: avkviring

Support sub project build without parent Cargo.toml.

d0d4c3a

avkviring requested review from Dylan-DPC-zz and a team as code owners June 29, 2020 17:05

reitermarkus requested changes Jun 29, 2020

View reviewed changes

Fix PR issues

0609329

reitermarkus requested changes Jun 30, 2020

View reviewed changes

avkviring added 2 commits June 30, 2020 08:36

Fix PR issues

1e03ee3

Fix PR issues

794d76d

avkviring requested a review from reitermarkus June 30, 2020 05:37

reitermarkus requested changes Jul 2, 2020

View reviewed changes

wngr mentioned this pull request Dec 4, 2020

feat: Parse Cargo's --manifest-path option to determine mounted docker root #494

Closed

humicro added a commit to humicro/cross that referenced this pull request Mar 15, 2021

Support sub project build without parent Cargo.toml.

e4070d6

cross-rs#438 credit: avkviring

avkviring closed this Jul 22, 2021

Support sub project build without parent Cargo.toml. #438

Support sub project build without parent Cargo.toml. #438

Uh oh!

Conversation

avkviring commented Jun 29, 2020

Uh oh!

avkviring commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reitermarkus commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reitermarkus commented Jul 16, 2020

Uh oh!

avkviring commented Jul 27, 2020

Uh oh!

wngr commented Dec 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avkviring commented Dec 3, 2020

Uh oh!

Uh oh!

avkviring commented Jun 29, 2020 •

edited

Loading

reitermarkus commented Jun 29, 2020 •

edited

Loading

wngr commented Dec 2, 2020 •

edited

Loading