-
Notifications
You must be signed in to change notification settings - Fork 1
Use native binaries when version exactly matches user input #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix typo
Oh, the CI is failing because it calls |
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
- Coverage 93.57% 87.71% -5.86%
==========================================
Files 4 4
Lines 140 171 +31
==========================================
+ Hits 131 150 +19
- Misses 9 21 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I guess the unit test could be added later, but it would go against having unit tests to begin with. I should apologize. Lately, I haven't been moving as fast as you might be used to for this project, but I have other projects that I'm trying to pursue. If you're uncomfortable working on my branch, then you could create a branch from this one and implement fixes/tests there. I'm ok with you pushing things to my branch because I've gotten used to git noobs high-jacking my branches... |
We could add unit tests and fix CI failures later. We can keep this branch to support It doesn't matter, take your time, this PR is all your contribution, I really really appreciate it. Actually, I'm sorry I haven't contributed much lately because I'm busy with my family, I'll try my best to respond quickly. |
I just pushed a commit that should fix the CI by using strict version checking. So, coverage took a -6% hit, so adding a new unit test would be good to bring that back over 90%... I agree we can do that later. |
Ready to release v0.6.0.