Skip to content

Use native binaries when version exactly matches user input #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 6, 2022

Conversation

shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Oct 6, 2022

Ready to release v0.6.0.

@shenxianpeng shenxianpeng added the enhancement New feature or request label Oct 6, 2022
@shenxianpeng shenxianpeng requested a review from 2bndy5 October 6, 2022 02:23
@2bndy5
Copy link
Contributor

2bndy5 commented Oct 6, 2022

Oh, the CI is failing because it calls clang-*-12.0.1 expecting to execute the clang binary for v12.0.1.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #33 (251278a) into main (5a1cae0) will decrease coverage by 5.85%.
The diff coverage is 65.71%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   93.57%   87.71%   -5.86%     
==========================================
  Files           4        4              
  Lines         140      171      +31     
==========================================
+ Hits          131      150      +19     
- Misses          9       21      +12     
Impacted Files Coverage Δ
clang_tools/install.py 82.69% <65.71%> (-9.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@2bndy5
Copy link
Contributor

2bndy5 commented Oct 6, 2022

I guess the unit test could be added later, but it would go against having unit tests to begin with.

I should apologize. Lately, I haven't been moving as fast as you might be used to for this project, but I have other projects that I'm trying to pursue. If you're uncomfortable working on my branch, then you could create a branch from this one and implement fixes/tests there. I'm ok with you pushing things to my branch because I've gotten used to git noobs high-jacking my branches...

@shenxianpeng
Copy link
Collaborator Author

shenxianpeng commented Oct 6, 2022

We could add unit tests and fix CI failures later. We can keep this branch to support choco on Windows later.

It doesn't matter, take your time, this PR is all your contribution, I really really appreciate it. Actually, I'm sorry I haven't contributed much lately because I'm busy with my family, I'll try my best to respond quickly.

@2bndy5
Copy link
Contributor

2bndy5 commented Oct 6, 2022

I just pushed a commit that should fix the CI by using strict version checking. So, -i 12 will look for v12.0.0, and -i 12.0.1 will look for v12.0.1, etc.

coverage took a -6% hit, so adding a new unit test would be good to bring that back over 90%... I agree we can do that later.

@2bndy5 2bndy5 linked an issue Oct 6, 2022 that may be closed by this pull request
@shenxianpeng shenxianpeng merged commit aeee5f6 into main Oct 6, 2022
@2bndy5 2bndy5 changed the title Use native binaries on Unix-like OS Use native binaries when version exactly matches user input Oct 6, 2022
@2bndy5 2bndy5 deleted the use-native-binaries branch October 6, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer dynamically built binaries when already installed
3 participants