Skip to content

Adding clicking outside of sidebar or aside on mobile closes the sidebar #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

JamesSingleton
Copy link

This takes care of #74

@JamesSingleton
Copy link
Author

@xidedix any update on this getting merged?

@xidedix
Copy link
Member

xidedix commented Jun 14, 2018

hi @JamesSingleton
Thanks for PR, I like your solution, it simply works. Just wondering if we can do it in React way and make Sidebar component aware of outside clicks. It is possible but requires some more code.

@JamesSingleton
Copy link
Author

Hi @xidedix ,

Thanks for your reply/ input, I will look it over this weekend and make another pull request.

@JamesSingleton
Copy link
Author

@xidedix so do you want me to make the changes in this repo then? https://github.com/coreui/coreui-react then?

@xidedix
Copy link
Member

xidedix commented Jun 15, 2018

@JamesSingleton
https://github.com/coreui/coreui-react is the place

@JamesSingleton
Copy link
Author

Awesome, thank you. I will take a look at it this weekend.

@xidedix
Copy link
Member

xidedix commented Oct 8, 2018

solved with @coreui/react ^2.0.5 and up

@xidedix xidedix closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants