fix(simulators): Consistency for filtering #2148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 90.64% 90.63% -0.01%
==========================================
Files 159 159
Lines 24039 24046 +7
==========================================
+ Hits 21789 21794 +5
- Misses 2250 2252 +2
🚀 New features to boost your workflow:
|
polomani
reviewed
Apr 30, 2025
polomani
reviewed
Apr 30, 2025
polomani
reviewed
Apr 30, 2025
polomani
approved these changes
May 22, 2025
polomani
added
waiting-for-risk-review
|
@doctrino @erlendvollset if any of you could have a look? |
polomani
reviewed
May 23, 2025
Comment on lines
+51
to
+52
| self.created_time: TimestampRange | None = None | ||
| self.last_updated_time: TimestampRange | None = None |
There was a problem hiding this comment.
Suggested change
| self.created_time: TimestampRange | None = None | |
| self.last_updated_time: TimestampRange | None = None | |
| self.created_time = created_time | |
| self.last_updated_time = last_updated_time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our API listing methods currently require an import to perform filtering, while others allow users to pass arguments directly without additional imports. To improve the user experience, we are standardizing on the latter approach across all instances.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.