-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
- Added feeback form from aitable base - Created a new component - 'airtable-form', which expects form id and height of the form. This can be used for both join and feedback forms. - Added feedback link in top navbar items. - Changed join page in order to use the new airtable-form component - Added /feedback path and page mapping in next.config.js - Added info related to feedback page in meta-info.json.
updated yarn.lock file after running yarn command.
Thanks so much for opening your first PR here! |
This pull request is automatically deployed with Now. Latest deployment for this branch: https://coderplex-git-fork-krushiraj-issue-529-add.coderplex.now.sh |
Deploy preview for coderplex ready! Built with commit 0c26990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the below comment!
Removed console log.
📝Changed routes:
Commit 0c26990 (https://coderplex-git-fork-krushiraj-issue-529-add.coderplex.now.sh). |
Sorry I didn't get this. |
@krushiraj Nevermind about it. It's auto-generated by now.sh bot. You can read more about it here https://zeit.co/blog/deploy-summary |
Observation: The nav links ul hieght was increased due to addition of new link in it. Due to which the top value of `-600%` couldn't make it hidden in collapsed state. Fix: In order make this dynamic, no matter how many links may be added or removed we should have the top value dynamic. - Observation resulted in conclusion that top should be 100% multiplied by (number of links in nav - 1). So added that as inline style when the nav is in collapsed state. - Removed top value from styles file. As that is redundant and unnecessary now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @krushiraj
🎉 🎉 🎊 Congrats on merging your first pull request! We here at coderplex.org are proud of you!. If you believe in our 📃 mission statement please ⭐ us. |
Added feedback form
No feedback form yet. #529
Added feedback form, similar to join form
Checklist for this PR
yarn lint
locally to format my code.yarn test
ran successfully.develop
branch.