Skip to content
This repository was archived by the owner on Mar 9, 2021. It is now read-only.

Issue 529 add #534

Merged
merged 7 commits into from
Sep 6, 2019
Merged

Issue 529 add #534

merged 7 commits into from
Sep 6, 2019

Conversation

krushiraj
Copy link
Contributor

@krushiraj krushiraj commented Sep 4, 2019

Added feedback form

No feedback form yet. #529

Added feedback form, similar to join form

Checklist for this PR

  • I have read contributing guidelines.
  • I executed yarn lint locally to format my code.
  • I added relevant Tests to verify my code. (N/A)
  • All tests yarn test ran successfully.
  • Pull request is towards develop branch.
  • I have tested the responsiveness of the UI by checking on devices using ScreenFly
  • Added myself to contributors table
  • Documentation
  • Ready to be merged

- Added feeback form from aitable base
- Created a new component - 'airtable-form', which expects form id and height of the form. This can be used for both join and feedback forms.
- Added feedback link in top navbar items.
- Changed join page in order to use the new airtable-form component
- Added /feedback path and page mapping in next.config.js
- Added info related to feedback page in meta-info.json.
updated yarn.lock file after running yarn command.
@welcome
Copy link

welcome bot commented Sep 4, 2019

Thanks so much for opening your first PR here!

@vercel
Copy link

vercel bot commented Sep 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://coderplex-git-fork-krushiraj-issue-529-add.coderplex.now.sh

@coderplex-bot
Copy link
Collaborator

coderplex-bot commented Sep 4, 2019

Deploy preview for coderplex ready!

Built with commit 0c26990

https://deploy-preview-534--coderplex.netlify.com

Copy link
Contributor

@vinaypuppal vinaypuppal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the below comment!

Removed console log.
@vinaypuppal
Copy link
Contributor

vinaypuppal commented Sep 5, 2019

@krushiraj
Copy link
Contributor Author

@vinaypuppal
Copy link
Contributor

@krushiraj Nevermind about it. It's auto-generated by now.sh bot. You can read more about it here https://zeit.co/blog/deploy-summary

@vinaypuppal vinaypuppal self-requested a review September 6, 2019 12:20
vinaypuppal
vinaypuppal previously approved these changes Sep 6, 2019
@vinaypuppal vinaypuppal dismissed their stale review September 6, 2019 12:22

Mobile nav is broken

@vinaypuppal
Copy link
Contributor

Mobile nav seems to be broken, I think we need to fix the top value which hides the mobile nav. Please check and fix it.

Screenshot 2019-09-06 at 5 52 30 PM

Observation: The nav links ul hieght was increased due to addition of new link in it. Due to which the top value of `-600%` couldn't make it hidden in collapsed state.

Fix:
In order make this dynamic, no matter how many links may be added or removed we should have the top value dynamic.

- Observation resulted in conclusion that top should be 100% multiplied by (number of links in nav - 1). So added that as inline style when the nav is in collapsed state.
- Removed top value from styles file. As that is redundant and unnecessary now.
Copy link
Contributor

@vinaypuppal vinaypuppal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krushiraj

@vinaypuppal vinaypuppal merged commit a9853d1 into coderplex-org:develop Sep 6, 2019
@welcome
Copy link

welcome bot commented Sep 6, 2019

🎉 🎉 🎊 Congrats on merging your first pull request! We here at coderplex.org are proud of you!. If you believe in our 📃 mission statement please ⭐ us.

@krushiraj krushiraj deleted the issue-529-add branch September 6, 2019 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants