-
Notifications
You must be signed in to change notification settings - Fork 13
Test/integrations #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good!
@kiran-chaudhary I was thinking about an approach this sort of like this:
Note that I am skipping the "delete all profiles" and "delete profile as part of cleanup activity" steps. This would allow us to set environment variables on our local machines for accounts that we already have profiles for to run these tests locally without having the profiles get deleted. Check out the bottom of this file: and this one: to see how I set this up for One thing that occurs to me is that in order to make this automatable, we would need to add (optional) flags that allow us to skip confirmation prompts, and that allow for the password to be input as part of the create-profile command. Those should probably be their own tasks, I'll get stories created for them. |
c9978c3
to
4a75e96
Compare
4a75e96
to
5a44a9a
Compare
Used |
5a44a9a
to
99a2b01
Compare
@kiran-chaudhary FYI I will usually assume that PRs that are marked as draft are not considered ready by the author, (except immediately after opening and asking for initial feedback), so be sure to mark them as ready for review. Just one small note about using |
Sorry I missed changing back to ready for review. |
Added setup for integration tests.