Skip to content

Feature/interactive errors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 4, 2020
Merged

Feature/interactive errors #9

merged 21 commits into from
Mar 4, 2020

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Mar 4, 2020

@alanag13
Something like this maybe

@antazoey antazoey requested a review from alanag13 March 4, 2020 16:54
@antazoey antazoey changed the title [WIP] Feature/interactive errors Feature/interactive errors Mar 4, 2020
alanag13
alanag13 suggested changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@alanag13 alanag13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough but a boolean seemed wrong to me. I think your tests will have to mock that situation somehow, too.

src/code42cli/securitydata/extraction.py Outdated


def _handle_result():
if not is_interactive() and _EXCEPTIONS_OCCURRED:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we wanted to print only if it was interactive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsy. Ok, I fixed it and added tests to make sure it stays fixed

@alanag13
Copy link
Contributor

alanag13 commented Mar 4, 2020

Fix the conflicts and then this looks good

alanag13
alanag13 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@alanag13 alanag13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@antazoey antazoey merged commit 77f6737 into master Mar 4, 2020
@antazoey antazoey deleted the feature/interactive-errors branch March 4, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanag13 alanag13 alanag13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @alanag13