Feature/support new search params #8
Conversation
We should definitely do this either way for any time someone does maybe for |
Yes |
|
Just made end_date go to 23:59:59 if you do not specify a time. This makes much more sense. If I give just a day, I'd expect to get all the events on that day. I am glad I caught this. |
src/code42cli/profile/config.py
Outdated
|
|
||
|
|
||
| def _get_config_profile_from_parser(parser): | ||
| config_file_path = _get_config_file_path() | ||
| parser.read(config_file_path) | ||
| parser.read(config_file_path) |
There was a problem hiding this comment.
this looks like a mistake (duplicate line)
README.md
Outdated
|
|
||
| To explicitly set your password, use `-p`: | ||
| (Optional) To set your password, use `--save-password`: |
There was a problem hiding this comment.
I think we're not using this anymore
src/code42cli/profile/profile.py
Outdated
| _try_set_authority_url(args) | ||
| _try_set_username(args) | ||
| _try_set_ignore_ssl_errors(args) | ||
| _try_set_password(args) | ||
| config.mark_as_set_if_complete() | ||
| _ask_if_they_would_like_to_set_their_password() |
There was a problem hiding this comment.
_prompt_for_allow_password_set or something similar, for consistency
src/code42cli/profile/profile.py
Outdated
| return True | ||
| def _ask_if_they_would_like_to_set_their_password(): | ||
| answer = get_input(u"Would you like to set a password? (y/n): ") | ||
| if answer == u"y": |
There was a problem hiding this comment.
if I enter Y here, (capital y), it wont store.
Requires https://github.com/code42/security-event-extractor/pull/7 to be merged first