Skip to content

fix dependencies #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
The intended audience of this file is for py42 consumers -- as such, changes that don't affect
how a consumer would use the library (e.g. adding unit tests, updating documentation, etc) are not captured here.

## 0.5.1 - 2020-04-27

### Fixed

- Issue that prevented version 0.5.0 from updating its dependencies properly.

- Issue that prevented the `add` and `bulk add` functionality of `departing-employee` and `high-risk-employee` from successfully adding users to lists when specifying optional fields.

## 0.5.0 - 2020-04-24

### Changed
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
package_dir={"": "src"},
python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, <4",
install_requires=[
"c42eventextractor",
"c42eventextractor==0.2.7",
"keyring==18.0.1",
"keyrings.alt==3.2.0",
"py42",
"py42>=1.0.0",
],
license="MIT",
include_package_data=True,
Expand Down
2 changes: 1 addition & 1 deletion src/code42cli/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.5.0"
__version__ = "0.5.1"
2 changes: 1 addition & 1 deletion src/code42cli/cmds/detectionlists/departing_employee.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def add_departing_employee(
notes: (str): Notes about the employee.
"""
user_id = get_user_id(sdk, username)
update_user(sdk, user_id, cloud_alias, notes=notes)
sdk.detectionlists.departing_employee.add(user_id, departure_date)
update_user(sdk, user_id, cloud_alias, notes=notes)


def remove_departing_employee(sdk, profile, username):
Expand Down
3 changes: 2 additions & 1 deletion src/code42cli/cmds/detectionlists/high_risk_employee.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def add_risk_tags(sdk, profile, username, risk_tag):
user_id = get_user_id(sdk, username)
sdk.detectionlists.add_user_risk_tags(user_id, risk_tag)


def remove_risk_tags(sdk, profile, username, risk_tag):
risk_tag = _handle_list_args(risk_tag)
user_id = get_user_id(sdk, username)
Expand All @@ -64,8 +65,8 @@ def add_high_risk_employee(sdk, profile, username, cloud_alias=None, risk_tag=No
"""
risk_tag = _handle_list_args(risk_tag)
user_id = get_user_id(sdk, username)
update_user(sdk, user_id, cloud_alias, risk_tag, notes)
sdk.detectionlists.high_risk_employee.add(user_id)
update_user(sdk, user_id, cloud_alias, risk_tag, notes)


def remove_high_risk_employee(sdk, profile, username):
Expand Down