fix python version requirements #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
alanag13
commented
Oct 21, 2021
| @@ -16,8 +16,7 @@ Use the `code42` command to interact with your Code42 environment. | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| - Python 3.6.0+ | |||
| - Code42 Server 6.8.x+ | |||
There was a problem hiding this comment.
got rid of this server reference because of on-prem deprecation
alanag13
commented
Oct 21, 2021
| install_requires=[ | ||
| "chardet", | ||
| "click>=7.1.1, <8", | ||
| "click_plugins>=1.1.1", | ||
| "colorama>=0.4.3", | ||
| "keyring==18.0.1", | ||
| "keyrings.alt==3.2.0", | ||
| "ipython>=7.16.1", | ||
| "ipython==7.16.1", |
There was a problem hiding this comment.
I pinned this version because theres a comment in ipython about versions later than it not supporting 3.6:
https://github.com/ipython/ipython/blob/967787ca35ad3e8731a34c26013ae32f875804a6/setup.py#L48
tora-kozic
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the cli on python 3.6.1 or 3.6.0, you will get
On startup. This is because
typing.NoReturnwas not introduced until python 3.6.2, and ipython references this module.This correctly updates our install requirements to require 3.6.2.