Skip to content

Feature/multiple profiles #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
Mar 12, 2020
Merged

Feature/multiple profiles #12

merged 68 commits into from
Mar 12, 2020

Conversation

antazoey
Copy link
Contributor

No description provided.

@alanag13
Copy link
Contributor

Some of the parameters are missing for the README, I noticed format and -i but there could be more

@alanag13
Copy link
Contributor

Also please resolve conflicts

@antazoey antazoey requested a review from alanag13 March 12, 2020 02:01
@alanag13
Copy link
Contributor

with profile set, it looks like none of the parameters are currently required. I would think-u and -s would be required if the profile passed into --profile does not exist yet (i.e. you are creating one), and that at least one of those should be required if the profile does exist.

@antazoey
Copy link
Contributor Author

with profile set, it looks like none of the parameters are currently required. I would think-u and -s would be required if the profile passed into --profile does not exist yet (i.e. you are creating one), and that at least one of those should be required if the profile does exist.

Talked offline and I just verified that the behavior works as we discussed... If your profile is not set up, it is required to give a profile name and at least a username or an authority url. If you only give one, it still is not setup and required you to set it before doing anything. If you have setup a default profile, it is not required but you will get prompted about changing your password. Slightly weird but still seems valid.

Copy link
Contributor

@alanag13 alanag13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@antazoey antazoey merged commit afb8a7d into master Mar 12, 2020
@antazoey antazoey deleted the feature/multiple-profiles branch March 12, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants