release-19.2: sql: fix bug where some session vars couldn't be set to "on" or "off" #46219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
i don't know what went wrong but TC is angry at your PR |
Session variables were incorrectly erroring out on string inputs even though string values of "on" and "off" are accepted. Fixes cockroachdb#46161. Release justification: bug fix Release note (bug fix): This PR fixes a bug where various session variables whose value would display as "on" or "off" could not be set to the values "on" or "off", only true or false.
rohany
force-pushed
the
backport19.2-46163
branch
from
8dd40be to
ba6c245
Compare
|
Woops, fixed |
|
cc @knz for stamp |
|
LGTM - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #46163.
/cc @cockroachdb/release
Session variables were incorrectly erroring out on
string inputs even though string values of "on" and
"off" are accepted.
Fixes #46161.
Release justification: bug fix
Release note (bug fix): This PR fixes a bug where various session
variables whose value would display as "on" or "off" could not be
set to the values "on" or "off", only true or false.